Skip to content

dynamic_modules: add Transport Socket ABI, SDK, and metrics support#44132

Merged
agrawroh merged 2 commits into
envoyproxy:mainfrom
agrawroh:rust-ktls-2
Mar 27, 2026
Merged

dynamic_modules: add Transport Socket ABI, SDK, and metrics support#44132
agrawroh merged 2 commits into
envoyproxy:mainfrom
agrawroh:rust-ktls-2

Conversation

@agrawroh
Copy link
Copy Markdown
Member

Description

This PR adds support for Transport Socket extensions in Dynamic Modules so that we can built kTLS and other functionality on top of it.


Commit Message: dynamic_modules: add Transport Socket ABI, SDK, and metrics support
Additional Description: Added support for Transport Socket extensions in Dynamic Modules
Risk Level: Low
Testing: Added Tests
Docs Changes: Added
Release Notes: N/A

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
* @return envoy_dynamic_module_type_transport_socket_io_result is the result of the read operation.
*/
envoy_dynamic_module_type_transport_socket_io_result
envoy_dynamic_module_on_transport_socket_do_read(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need "do" here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's coming from TransportSocket::doRead() / TransportSocket::doWrite() which we have in envoy/network/transport_socket.

* operation.
*/
envoy_dynamic_module_type_transport_socket_io_result
envoy_dynamic_module_on_transport_socket_do_write(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will keep it for consistency.

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
@agrawroh agrawroh merged commit cc7452e into envoyproxy:main Mar 27, 2026
29 checks passed
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Apr 1, 2026
citrus7 pushed a commit to citrus7/envoy that referenced this pull request Apr 1, 2026
nshipilov pushed a commit to nshipilov/envoy that referenced this pull request Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants