Skip to content

hickory_dns: slightly optimize how we maintain shared states#44175

Merged
agrawroh merged 1 commit into
envoyproxy:mainfrom
agrawroh:feat-hick-dns-4
Mar 31, 2026
Merged

hickory_dns: slightly optimize how we maintain shared states#44175
agrawroh merged 1 commit into
envoyproxy:mainfrom
agrawroh:feat-hick-dns-4

Conversation

@agrawroh
Copy link
Copy Markdown
Member

Description

This PR slightly optimizes how we maintain shared state in Hickory DNS by bundling it in.


Commit Message: hickory_dns: slightly optimize how we maintain shared states
Additional Description: Adds optimizations around how we maintain shared state in Hickory DNS by bundling it in.
Risk Level: Low
Testing: Added Tests
Docs Changes: N/A
Release Notes: N/A

@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #44175 was opened by agrawroh.

see: more, trace.

@agrawroh agrawroh marked this pull request as ready for review March 31, 2026 07:42
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @agrawroh

@agrawroh agrawroh enabled auto-merge (squash) March 31, 2026 09:38
@agrawroh agrawroh merged commit 0b8ac62 into envoyproxy:main Mar 31, 2026
28 checks passed
TAOXUY pushed a commit to TAOXUY/envoy that referenced this pull request Apr 1, 2026
…oxy#44175)

## Description

This PR slightly optimizes how we maintain shared state in Hickory DNS
by bundling it in.

---

**Commit Message:** hickory_dns: slightly optimize how we maintain
shared states
**Additional Description:** Adds optimizations around how we maintain
shared state in Hickory DNS by bundling it in.
**Risk Level:** Low
**Testing:** Added Tests
**Docs Changes:** N/A
**Release Notes:** N/A

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
citrus7 pushed a commit to citrus7/envoy that referenced this pull request Apr 1, 2026
…oxy#44175)

## Description

This PR slightly optimizes how we maintain shared state in Hickory DNS
by bundling it in.

---

**Commit Message:** hickory_dns: slightly optimize how we maintain
shared states
**Additional Description:** Adds optimizations around how we maintain
shared state in Hickory DNS by bundling it in.
**Risk Level:** Low
**Testing:** Added Tests
**Docs Changes:** N/A
**Release Notes:** N/A

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Jonathan Wu <jtwu@google.com>
nshipilov pushed a commit to nshipilov/envoy that referenced this pull request Apr 13, 2026
…oxy#44175)

## Description

This PR slightly optimizes how we maintain shared state in Hickory DNS
by bundling it in.

---

**Commit Message:** hickory_dns: slightly optimize how we maintain
shared states
**Additional Description:** Adds optimizations around how we maintain
shared state in Hickory DNS by bundling it in.
**Risk Level:** Low
**Testing:** Added Tests
**Docs Changes:** N/A
**Release Notes:** N/A

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
krinkinmu pushed a commit to grnmeira/envoy that referenced this pull request Apr 20, 2026
…oxy#44175)

## Description

This PR slightly optimizes how we maintain shared state in Hickory DNS
by bundling it in.

---

**Commit Message:** hickory_dns: slightly optimize how we maintain
shared states
**Additional Description:** Adds optimizations around how we maintain
shared state in Hickory DNS by bundling it in.
**Risk Level:** Low
**Testing:** Added Tests
**Docs Changes:** N/A
**Release Notes:** N/A

Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants