feat: ability to set status for destination not found in stateful session#44210
Merged
phlax merged 5 commits intoApr 14, 2026
Merged
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
…sion Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
force-pushed
the
strict_stateful_session_status_notfound
branch
from
bce1e8f to
ce2bca6
Compare
mattklein123
previously approved these changes
Apr 4, 2026
Member
|
Needs main merge otherwise lgtm, thanks. /wait |
Member
Author
|
/retest |
phlax
reviewed
Apr 14, 2026
| // The HTTP status code to return when ``strict`` mode is enabled and the requested destination | ||
| // is not found in the set of available endpoints. This does not apply when the destination exists | ||
| // but is unhealthy. This field has no effect when ``strict`` is set to ``false`` and will be | ||
| // ignored. Defaults to 503 (Service Unavailable) if not specified or set to 0. |
Member
There was a problem hiding this comment.
Suggested change
| // ignored. Defaults to 503 (Service Unavailable) if not specified or set to 0. | |
| // ignored. Defaults to ``503`` (Service Unavailable) if not specified or set to ``0``. |
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
phlax
approved these changes
Apr 14, 2026
Member
Author
|
/retest |
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…sion (envoyproxy#44210) Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: feat: ability to set status for destination not found in stateful session
Additional Description: Follow up for #43944 to add the
status_on_strict_destination_not_foundto allow users to define status to respond with if strict destination doesn't exist.Risk Level: Low (new API)
Testing: Unit testing
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Fixes: #42686