Add configuration for RLS response metadata namespace#44531
Open
yanavlasov wants to merge 2 commits intoenvoyproxy:mainfrom
Open
Add configuration for RLS response metadata namespace#44531yanavlasov wants to merge 2 commits intoenvoyproxy:mainfrom
yanavlasov wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Member
|
kindly ping @wbpcode @markdroth |
wbpcode
reviewed
Apr 27, 2026
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM with minor comment to the comment of API.
/wait
| repeated config.route.v3.RateLimit rate_limits = 17; | ||
|
|
||
| // The namespace where dynamic metadata from rate limit response is saved. | ||
| // If not set, the default is "envoy.extensions.filters.http.ratelimit". |
Member
There was a problem hiding this comment.
Suggested change
| // If not set, the default is "envoy.extensions.filters.http.ratelimit". | |
| // If not set, the default is "envoy.filters.http.ratelimit". |
?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option for modifying the default namespace where HTTP filter stores metadata from the rate limit service response. This allows rate limit results to influence behavior of other extensions.
Risk Level: low (new config option)
Testing: unit tests
Docs Changes: yes
Release Notes: yes
Platform Specific Features: no