Add SKIP_CHECK_FORMAT environment variable to skip check_format when …#455
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Feb 9, 2017
Merged
Conversation
…iterating locally. It's somewhat distracting to be forced to fix_format while debugging.
mattklein123
approved these changes
Feb 9, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
… class (envoyproxy#455) * create EVP_MD object in JwtVerifier constructor * split verification function into another class * update merged part according to this PR * add TODO comment
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Apr 24, 2020
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
bianpengyuan
added a commit
to bianpengyuan/envoy
that referenced
this pull request
May 15, 2020
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
May 18, 2020
Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Update `Rotate` to return the expiration time in addition to the error. This will allow us to get the expiration time without having to make a `GET` API request to Kubernetes. **Related Issues/PRs (if applicable)** https://github.com/envoyproxy/ai-gateway/blob/8f38c672ee11e6e724fff7b1e430979417fd3ce6/internal/controller/backend_security_policy.go#L106-L108 ``` 2025-03-02T20:12:23Z INFO controller.backend-security-policy successfully rotated credentials for credentials in namespace default of auth type AWSCredentials, renewing in -0.009733 minutes ``` The requeue time after rotating a set of credentials (AWS in this case) returns a negative number of minutes occasionally. It requires a manual action/global sync to restart the rotation logic. Upon further investigation, the issue found lies with `rotator.GetPreRotationTime` returning the incorrect time. GetPreRotation gets the expiration time from the secret's annotation, and the assumption is it's getting a cached previous secret's annotation instead of the new expiration time. https://github.com/envoyproxy/ai-gateway/blob/8f38c672ee11e6e724fff7b1e430979417fd3ce6/internal/controller/backend_security_policy.go#L143-L147 --------- Signed-off-by: Aaron Choo <achoo30@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iterating locally.
It's somewhat distracting to be forced to fix_format while debugging.