Revert aa9478f06d613cd7b845e609a8c20c1ce116dad5#4581
Merged
Conversation
added 2 commits
October 1, 2018 15:21
This reverts commit aa9478f. Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Member
Author
mattklein123
approved these changes
Oct 1, 2018
Contributor
|
I will file an issue and take a look. As @junr03 pointed out, it seems the delayed close timeout callback is being issued after a |
jmarantz
added a commit
to jmarantz/envoy
that referenced
this pull request
Oct 3, 2018
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
deleted the
revert-aa9478f06d613cd7b845e609a8c20c1ce116dad5
branch
aa-stripe
pushed a commit
to aa-stripe/envoy
that referenced
this pull request
Oct 11, 2018
This PR reverts envoyproxy#4382. When deploying at Lyft we noticed crashes on here where we might be derefencing the connection_stats_ pointer after the point has been reset. Note: this PR keeps the changes to the API made in the original PR but tags the field as not implemented. This is what we have done in the past for reverts that involve changes that change the API. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: Aaltan Ahmad <aa@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #4382. When deploying at Lyft we noticed crashes on here where we might be derefencing the connection_stats_ pointer after the point has been reset.
Note: this PR keeps the changes to the API made in the original PR but tags the field as not implemented. This is what we have done in the past for reverts that involve changes that change the API.