tcp_proxy: remove support for v1 routes

[venilnoronha]

Description: This PR removes the previously deprecated v1 routes support in the TCP Proxy implementation. See #4622, #4487 and #4430 for more information.
Risk Level: Med
Testing: Existing tests suffice
Docs Changes: Added feature removal notice to version_history.rst
Release Notes: NA

Signed-off-by: Venil Noronha veniln@vmware.com

/cc @ggreenway @rshriram

[ggreenway]

Unfortunately, (and I feel bad saying this after all the back and forth about when we can do this), I'm not sure we can delete this yet, because in FilterChainMatch (the new way of doing this), we still have:

  // [#not-implemented-hide:]
  repeated core.CidrRange source_prefix_ranges = 6;

So if we delete this, there's no way to configure routing based on source address (to the best of my understanding).

@rshriram Does this seem correct? Or am I missing something?

[mattklein123]

So if we delete this, there's no way to configure routing based on source address (to the best of my understanding).

FYI this was recently asked about: #4535 (comment). Perhaps we can just get it implemented?

[venilnoronha]

Sure, let's see what @rshriram and @PiotrSikora have to say.

[stale]

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[venilnoronha]

not stale.

[PiotrSikora]

IMHO, we need at least one release that supports both: the new-style filter chain matching based on source ports/IPs (#4457) and old-style v1 tcp proxy, which this PR removes.

[rshriram]

sorry I missed this. Yes, we will miss source matching. But I don't think anyone is using it are they? docs are hiding source match. Istio isn't using it either for sure.
We have been saying that v1 is going to be deprecated and I view this as part of v1 removal.

[rshriram]

I mean v1 api is going away.. and this is part of that process

[stale]

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[venilnoronha]

not stale.

[stale]

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[stale]

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[venilnoronha]

This PR is synced with master now.

[venilnoronha]

/retest

[repokitteh-read-only]

🔨 rebuilding ci/circleci: ipv6_tests (failed build)

🐱

Caused by: a #4625 (comment) was created by @venilnoronha.

see: more, trace.

[mattklein123]

@ggreenway @PiotrSikora I haven't been following the history here. Can we merge this now?

[ggreenway]

I quick check shows no change in the blockers for this: source_prefix_ranges is still not implemented.

[mattklein123]

OK then I will close this for now since it's not going to get merged any time soon.