test: correct x-envoy-retry-grpc-on header used in test#4663
Merged
alyssawilk merged 1 commit intoenvoyproxy:masterfrom Oct 10, 2018
Merged
test: correct x-envoy-retry-grpc-on header used in test#4663alyssawilk merged 1 commit intoenvoyproxy:masterfrom
alyssawilk merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Snow Pettersen <snowp@squareup.com>
Contributor
Author
|
Also happy to fix the test if anyone knows what it's supposed to be testing |
alyssawilk
approved these changes
Oct 10, 2018
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
AFIK it's basically testing that the HCM state machine is happy. the actual retry. The actual headers are checked in retry_state_impl_test.cc
Member
I just looked at this and I agree this test probably doesn't add any value for the actual header since it's using a mock retry state. It's probably worth deleting any duplication of this type of test in this file, since it's possible people kept copy/pasting assuming it was testing something else. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the correct header key for grpc retry policy. Not sure what the purpose of this test is given the test seems to pass even without the header (retry decision is mocked out, it doesn't depend on the header), but at least now it's setting the right header.
Risk Level: Low