stats: Move stats impl discussion from thread_local_store.h into source/doc/stats/md#4729
Merged
htuch merged 6 commits intoenvoyproxy:masterfrom Oct 16, 2018
Merged
Conversation
…stats.md A few TBD sections were added to suggest structure, but the intent is not to fill them out in this PR, which just moves the existing material and adds an overview for contex. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
|
Please pull #4727 for the fix to v6 tests. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
htuch
suggested changes
Oct 15, 2018
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, some surface changes requested.
Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
commented
Oct 15, 2018
Contributor
Author
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
done -- made some of the double-quotes into italics, others into backquotes when the enclosed word is a C++ thing as opposed to a concept.
soya3129
pushed a commit
to soya3129/envoy
that referenced
this pull request
Oct 19, 2018
…ce/doc/stats/md (envoyproxy#4729) per @mattklein123 's suggestion on envoyproxy#4711 , adds a stats design doc. In this rev it only pulls in material from a comment in thread_local_store.h. A few TBD sections were added to suggest structure, but the intent is not to fill them out in this PR, which just moves the existing material and adds an overview for context. Future stats-related PRs should include edits to this file to keep it up-to-date. This is one step toward resolving envoyproxy#4196. Risk Level: low Testing: none Docs Changes: this is a doc change. Release Notes: n/a Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Yang Song <yasong@yasong00.cam.corp.google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: per @mattklein123 's suggestion on #4711 , adds a stats design doc. In this rev it only pulls in material from a comment in thread_local_store.h. A few TBD sections were added to suggest structure, but the intent is not to fill them out in this PR, which just moves the existing material and adds an overview for context. Future stats-related PRs should include edits to this file to keep it up-to-date.
This is one step toward resolving #4196.
Risk Level: low
Testing: none
Docs Changes: this is a doc change.
Release Notes: n/a