bazel: Allow to distdir all dependencies#4779
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Oct 20, 2018
vadorovsky:distdir
Merged
bazel: Allow to distdir all dependencies#4779mattklein123 merged 5 commits intoenvoyproxy:masterfrom vadorovsky:distdir
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
vadorovsky:distdir
Conversation
Contributor
Author
|
@lizan PTAL |
lizan
suggested changes
Oct 18, 2018
Member
There was a problem hiding this comment.
good to know we don't need to use new_http_archive anymore 👍
Member
There was a problem hiding this comment.
only grep bazel/ and api/bazel directory? or use -r instead of -R then you don't need exclude-dir.
lizan
reviewed
Oct 18, 2018
Functions native.http_archive and native.new_http_archive are deprecated. The function http_archive from repo:http.bzl should be used instead. The new function supports patching of http archives, so patched_http_archive.bzl is not needed anymore. Signed-off-by: Michal Rostecki <mrostecki@suse.de>
To use --distdir option of Bazel (which allows to use previously fetched tarballs instead of downloading dependencies during build), all dependencies should use http instead of git and need to have sha256 sums specified. Risk Level: low Testing: n/a Docs Changes: updated bazel/EXTERNAL_DEPS.md Release Notes: n/a Signed-off-by: Michal Rostecki <mrostecki@suse.de>
check_repositories.sh checks whether repositories definitions allow all dependencies to be prefetched and stored in distdir. It means meeting the following criteria: - Using only HTTP repositories, not using git repositories. - SHA256 sum defined for each repository. Signed-off-by: Michal Rostecki <mrostecki@suse.de>
Check repositories definitions correctness on `git push`. Signed-off-by: Michal Rostecki <mrostecki@suse.de>
Check repositories definitions correctness in `format` CI job. Signed-off-by: Michal Rostecki <mrostecki@suse.de>
Contributor
Author
|
@lizan Comments addressed |
lizan
approved these changes
Oct 19, 2018
vadorovsky
added a commit
to vadorovsky/cilium
that referenced
this pull request
Oct 29, 2018
To use --distdir option of Bazel (which allows to use previously fetched tarballs instead of downloading dependencies during build), all dependencies should use http instead of git and need to have sha256 sums specified. Envoy needs to be updated to version which contains the following PR: envoyproxy/envoy#4779 Signed-off-by: Michal Rostecki <mrostecki@suse.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use --distdir option of Bazel (which allows to use previously
fetched tarballs instead of downloading dependencies during
build), all dependencies should use http instead of git and need
to have sha256 sums specified.
Risk Level: low
Testing: n/a
Docs Changes: updated
bazel/EXTERNAL_DEPS.mdRelease Notes: n/a
Signed-off-by: Michal Rostecki mrostecki@suse.de