Add release notes for json logging and fix a typo#4784
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Oct 20, 2018
Merged
Add release notes for json logging and fix a typo#4784mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Aaltan Ahmad <aa@stripe.com>
Contributor
Author
|
Tagging @htuch |
mattklein123
previously approved these changes
Oct 19, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks. Sorry I crossed my other message with this.
Contributor
Author
|
Np! |
htuch
reviewed
Oct 19, 2018
|
|
||
| 1.9.0 (pending) | ||
| =============== | ||
| * access log: added a :ref:`JSON logging mode <config_access_log_format_dictionaries>` to output access logs in JSON format |
Member
There was a problem hiding this comment.
Very OCD nit: can you add a . to the end of the sentence?
Signed-off-by: Aaltan Ahmad <aa@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #4693
(
access_log.rstwas missing the trailing newline - other files in the same directory have it. Let me know if you want it removed)Description: Add release notes for JSON logging. Fix a casing typo.
Risk Level: Low
Testing: Built docs and checked links work
Docs Changes: Fix a typo in the access log config docs
Release Notes: Release notes for JSON logging