Stats speed test#4867
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Oct 28, 2018
Merged
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This was referenced Oct 26, 2018
| private: | ||
| Stats::StatsOptionsImpl options_; | ||
| Event::SimulatedTimeSystem time_system_; | ||
| Stats::HeapStatDataAllocator heap_alloc_; |
Member
There was a problem hiding this comment.
Is it worth it to have a variant of this test that use shared memory? I'm guessing for most of the things we care about (cached fast path) it doesn't really matter, but possibly worth putting in a TODO like you did for the MT thread contention case below?
Contributor
Author
There was a problem hiding this comment.
yes, good idea; done.
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
Oct 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: adds a speed-test measuring the single-threaded performance of the stats store with and without tls. of course every machine is different, but on mine a typical run gives results similar to this:
with variances in the single-digit percent range. This should help quantify the perf impact of potential changes to the stats system, to justify #4711 and #4715
Risk Level: low
Testing: only the new test
Docs Changes:
Release Notes: