tls: refactor tls tests#4958
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Nov 5, 2018
Merged
Conversation
Signed-off-by: Rama <rama.rao@salesforce.com>
Contributor
Author
jmarantz
reviewed
Nov 4, 2018
| static void loadConfig(ServerContextConfigImpl& cfg, Event::TestTimeSystem& time_system) { | ||
| ContextManagerImpl manager(time_system); | ||
| Stats::IsolatedStoreImpl store; | ||
| static void loadConfig(ServerContextConfigImpl& cfg, ContextManagerImpl& manager, |
Contributor
There was a problem hiding this comment.
why not make this non-static so manager and store can be ref'd from class?
Contributor
Author
There was a problem hiding this comment.
Yes. Agree. We can change it like that.
| manager.createSslServerContext(store, cfg, std::vector<std::string>{})); | ||
| } | ||
|
|
||
| static void loadConfigV2(envoy::api::v2::auth::DownstreamTlsContext& cfg, |
| } | ||
|
|
||
| static void loadConfigYaml(const std::string& yaml, Event::TestTimeSystem& time_system) { | ||
| static void loadConfigYaml(const std::string& yaml, ContextManagerImpl& manager, |
Signed-off-by: Rama <rama.rao@salesforce.com>
Contributor
Author
|
@jmarantz made the methods non-static. PTAL. |
lizan
approved these changes
Nov 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: One of the review suggestions in #4810 is to move some of the variable initialization to class level. Here is the related discussion . This PR addresses that feedback.
Risk Level: Low
Testing: Existing automated tests
Docs Changes: N/A
Release Notes: N/A