stats: adds a speed-test for accumulating http response stats#4998
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Nov 9, 2018
Merged
stats: adds a speed-test for accumulating http response stats#4998mattklein123 merged 3 commits intoenvoyproxy:masterfrom
mattklein123 merged 3 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
Nov 8, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, great place to start. Obviously if you eventually do an optimization around common HTTP codes we might need to make this a bit more complex, but seems good for now.
| } | ||
| BENCHMARK(BM_ResponseTiming); | ||
|
|
||
| // Boilerplate main(), which discovers benchmarks in the same file and runs them. |
Member
There was a problem hiding this comment.
As an aside, I feel like we have this now in a lot of different files. Is there anyway to make this a little less copy/paste?
Contributor
Author
There was a problem hiding this comment.
agreed -- should be able to just put that main() into a new source/common/common/benchmark.h, though in some case you may need a global init (because statics). Follow-up OK? I'd do that across all the speed-tests in our repo.
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…roxy#4998) Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This serves as a baseline for the speed improvements offered in #4997 . With this PR, on my machine, I get:
which appears to be fairly consistent, at least localized in time.
Risk Level: low -- just adds a new speed test
Testing: just this test
Docs Changes: n/a
Release Notes: n/a