tests: fix unit test for cors filter#5124
Closed
dschaller wants to merge 2 commits intoenvoyproxy:masterfrom
Closed
tests: fix unit test for cors filter#5124dschaller wants to merge 2 commits intoenvoyproxy:masterfrom
dschaller wants to merge 2 commits intoenvoyproxy:masterfrom
Conversation
added 2 commits
November 26, 2018 14:15
Signed-off-by: Derek Schaller <dschaller@lyft.com>
Signed-off-by: Derek Schaller <dschaller@lyft.com>
Member
Author
|
Mind taking a look @codesuki ? |
Member
Author
|
I think I misunderstood the intent of the test. Opened #5125 to hopefully clarify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix unit test in CORS filter to match the desired behavior.
Risk Level: Low
Testing: Ran unit tests.
Docs Changes: N/A
Release Notes: N/A