test: fix some flakes that might relate to #5104.#5211
Merged
Conversation
* Need to be prepared to handle disconnection when resetting the server in HttpIntegrationTest::testRouterHeaderOnlyRequestAndResponse. * HttpIntegrationTest::testUpstreamDisconnectWithTwoRequests was racy. It was possible before for both requests to be load balanced and sent to the first upstream connection. When the 200 for the first request is received, we would then disconnect the upstream. This would then 503 back. Risk Level: Low Testing: 1k runs on internal build farm, most flakes disappeared. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
Resuming #5172 here. BTW, this doesn't fix all flakes, just the most common. I'll hand off to the current on-call to continue the saga. |
alyssawilk
reviewed
Dec 4, 2018
| IntegrationCodecClientPtr codec_client2 = makeHttpConnection(lookupPort("http")); | ||
| auto response2 = codec_client2->makeRequestWithBody(default_request_headers_, 512); | ||
|
|
||
| // Validate one request active, the other pending. |
Contributor
There was a problem hiding this comment.
optional nit: Validate that one request is active, the other pending.
(deflaking CI is more important so feel free to land as-is)
alyssawilk
approved these changes
Dec 4, 2018
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Awesome, thanks both for deflaking CI and sorting out how to make this test reliably do what we want it to do.
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…xy#5211) * Need to be prepared to handle disconnection when resetting the server in HttpIntegrationTest::testRouterHeaderOnlyRequestAndResponse. * HttpIntegrationTest::testUpstreamDisconnectWithTwoRequests was racy. It was possible before for both requests to be load balanced and sent to the first upstream connection. When the 200 for the first request is received, we would then disconnect the upstream. This would then 503 back. Risk Level: Low Testing: 1k runs on internal build farm, most flakes disappeared. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to be prepared to handle disconnection when resetting the server in
HttpIntegrationTest::testRouterHeaderOnlyRequestAndResponse.
HttpIntegrationTest::testUpstreamDisconnectWithTwoRequests was racy. It was possible before for
both requests to be load balanced and sent to the first upstream connection. When the 200 for the
first request is received, we would then disconnect the upstream. This would then 503 back.
Risk Level: Low
Testing: 1k runs on internal build farm, most flakes disappeared.
Signed-off-by: Harvey Tuch htuch@google.com