complete ssl_socket_test refactoring#5429
Merged
mattklein123 merged 3 commits intoenvoyproxy:masterfrom Dec 26, 2019
Merged
Conversation
Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
Bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
vadimeisenbergibm
changed the title
Contributor
Author
|
@PiotrSikora Could you please reopen this PR? |
stale
Bot
removed
the
stale
Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com>
Contributor
Author
|
@dio Thank you for reopening this PR! Could you please review it? It is tiny: two lines removed and three lines added. |
prakhag1
pushed a commit
to prakhag1/envoy
that referenced
this pull request
Jan 3, 2020
Signed-off-by: Vadim Eisenberg <vadime@il.ibm.com> Signed-off-by: Prakhar <prakhar_au@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vadim Eisenberg vadime@il.ibm.com
To complete #5402
Description: Complete ssl_socket_test refactoring
Risk Level: zero
Testing: the test itself
Docs Changes: none
Release Notes: