For QUICHE integration, add --experimental_remap_main_repo to bazelrc.#5759
For QUICHE integration, add --experimental_remap_main_repo to bazelrc.#5759wu-bin wants to merge 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Bin Wu <wub@google.com>
|
Associated with #2557 For context, this flag is temporarily necessary in order for the Envoy QUICHE platform implementation to be able to depend on Envoy libraries, without incurring link-time errors. More explanation in this comment. Bazel team's plan for graduating the flag-protected behavior is described here. Note that the Bazel fix is only available in the most recent Bazel release, 0.22.0, which was released yesterday. @htuch , are there timing considerations around when a PR can assume the most recent version of Bazel? |
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
LGTM, just one (optional) comment
|
|
||
| # Test options | ||
| test --test_env=HEAPCHECK=normal --test_env=PPROF_PATH | ||
| test --test_env=HEAPCHECK=normal --test_env=PPROF_PATH --experimental_remap_main_repo |
There was a problem hiding this comment.
nit: since 'test' options inherit from 'build' options (at least according to .bazelrc doc), can you leave out specifying the flag here?
Signed-off-by: Bin Wu <wub@google.com>
wu-bin
left a comment
wu-bin
left a comment
There was a problem hiding this comment.
Removed --experimental_remap_main_repo from the test command.
Signed-off-by: Bin Wu <wub@google.com>
|
I have messed up this PR by doing commit, without DCO, from the github web ui. I'll close this and create a new PR for this. |
2 participants
Description:
To allow source/extensions/quic_listeners/quiche/platform:quic_platform_impl_lib to depend on envoy build rules, add --experimental_remap_main_repo to bazelrc.
See #5548 for context.
Risk Level: minimal: build only
Testing: Tested build with PR #5758
Docs Changes: none
Release Notes: none
[Optional Fixes #Issue]
[Optional Deprecated:]