ext_authz: makes gRPC service cross-compatible with V2 and V2alpha.#5825
Merged
mattklein123 merged 13 commits intoenvoyproxy:masterfrom Feb 9, 2019
Merged
ext_authz: makes gRPC service cross-compatible with V2 and V2alpha.#5825mattklein123 merged 13 commits intoenvoyproxy:masterfrom
mattklein123 merged 13 commits intoenvoyproxy:masterfrom
Conversation
added 5 commits
January 26, 2019 13:26
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
mattklein123
requested changes
Feb 4, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks this looks right. Thanks for the quick fix! A few comments.
/wait
Member
|
Please merge master to pick up #5827. |
added 2 commits
February 4, 2019 18:30
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
gsagula
changed the title
mattklein123
requested changes
Feb 5, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Looks good, thanks. Few small things. Also please merge master and run fix format to get the java proto changes.
/wait
Signed-off-by: Gabriel <gsagula@gmail.com>
added 3 commits
February 5, 2019 20:32
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Signed-off-by: Gabriel <gsagula@gmail.com>
Member
Author
|
I'm not sure why |
Member
Member
Author
|
@mattklein123 Sounds good, thanks. I will merge master when he finishes it. Other than that, I the code is good for another pass. |
Signed-off-by: Gabriel <gsagula@gmail.com>
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
…nvoyproxy#5825) Signed-off-by: Gabriel <gsagula@gmail.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5727.
Risk Level: medium
Testing: unit tests
Docs Changes: yes
Release Notes: yes