Skip to content

Limit error spew from compiler. #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 2 commits into from
Mar 22, 2017
Merged

Limit error spew from compiler. #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6548370
Limit error spew from compiler.
htuch Mar 22, 2017
3fc6c63
Make limit opt-in for cmake.
htuch Mar 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bazel/envoy_build_system.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
ENVOY_COPTS = [
"-fno-omit-frame-pointer",
"-fmax-errors=3",
"-Wall",
"-Wextra",
"-Werror",
Expand Down
10 changes: 5 additions & 5 deletions ci/build_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ export PPROF_PATH=/thirdparty_build/bin/pprof
NUM_CPUS=`grep -c ^processor /proc/cpuinfo`

if [[ "$1" == "coverage" ]]; then
EXTRA_CMAKE_FLAGS="-DENVOY_CODE_COVERAGE:BOOL=ON"
EXTRA_CMAKE_FLAGS+=" -DENVOY_CODE_COVERAGE:BOOL=ON"
elif [[ "$1" == "asan" ]]; then
EXTRA_CMAKE_FLAGS="-DENVOY_SANITIZE:BOOL=ON -DENVOY_DEBUG:BOOL=OFF"
EXTRA_CMAKE_FLAGS+=" -DENVOY_SANITIZE:BOOL=ON -DENVOY_DEBUG:BOOL=OFF"
elif [[ "$1" == "debug" ]]; then
EXTRA_CMAKE_FLAGS="-DENVOY_DEBUG:BOOL=ON"
EXTRA_CMAKE_FLAGS+=" -DENVOY_DEBUG:BOOL=ON"
elif [[ "$1" == "server_only" ]]; then
EXTRA_CMAKE_FLAGS="-DENVOY_DEBUG:BOOL=OFF -DENVOY_STRIP:BOOL=ON"
EXTRA_CMAKE_FLAGS+=" -DENVOY_DEBUG:BOOL=OFF -DENVOY_STRIP:BOOL=ON"
else
EXTRA_CMAKE_FLAGS="-DENVOY_DEBUG:BOOL=OFF"
EXTRA_CMAKE_FLAGS+=" -DENVOY_DEBUG:BOOL=OFF"
fi

mkdir -p build_"$1"
Expand Down
5 changes: 5 additions & 0 deletions common.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -ggdb3 -fno-omit-frame-pointer -Wall -Wextra -Werror -Wnon-virtual-dtor -Woverloaded-virtual -Wold-style-cast -std=c++0x")

option(ENVOY_LIMIT_ERROR_LOG "limit the number of error log lines from compiler" OFF)
if (ENVOY_LIMIT_ERROR_LOG)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fmax-errors=3")
endif()

if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS "4.9")
message(FATAL_ERROR "gcc >= 4.9 required for regex support")
Expand Down