[WIP] upstream: Fallback policy per subset selector support#6124
[WIP] upstream: Fallback policy per subset selector support#6124nezdolik wants to merge 1 commit intoenvoyproxy:masterfrom nezdolik:subset-lb-opt
Conversation
Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
| LbSubsetMap subsets_; | ||
| // Forms a trie-like structure of lexically sorted keys+optional fallback policy from subset | ||
| // selectors configuration | ||
| SubsetSelectorMap selectors_; |
There was a problem hiding this comment.
What's the reason you need to maintain a separate trie for this? Wouldn't the structure of this match subsets_ in such a way that you could embed the new fallback policy into the nodes of that?
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
Bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
2 participants
Signed-off-by: Kateryna Nezdolii nezdolik@spotify.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]