kafka: avoiding referencing data() when it is empty#6827
Closed
alyssawilk wants to merge 2 commits intoenvoyproxy:masterfrom
Closed
kafka: avoiding referencing data() when it is empty#6827alyssawilk wants to merge 2 commits intoenvoyproxy:masterfrom
alyssawilk wants to merge 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
previously approved these changes
May 6, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM assuming this fixes ASAN. @adamkotwasinski PTAL
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
Alas, did not fix. @adamkotwasinski could you try reproing locally? |
Contributor
|
@alyssawilk just raised #6831 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopefully fixing CI asan unhappiness. For some reason asan is borked locally so I'm testing on CI today :-(
Risk Level: low (minor change to new code)
Testing: Will merge if ASAN CI is happy
Docs Changes: n/a
Release Notes: n/a