Use the Zipkin library to support Zipkin tracing#700
Closed
fabolive wants to merge 9 commits into
Closed
Conversation
Merged
RomanDzhabarov
suggested changes
Apr 7, 2017
| "access_token_file" : {"type" : "string"}, | ||
| "endpoint": {"type": "string"} | ||
| }, | ||
| "required": ["collector_cluster", "access_token_file"], |
Member
There was a problem hiding this comment.
this should be done in a way that there are separate schemas for different driver types, otherwise schema will not have much value.
| #include "common/runtime/uuid_util.h" | ||
|
|
||
| #include "zipkin/zipkin_core_constants.h" | ||
| #include <iostream> |
| } | ||
|
|
||
| void ZipkinReporter::onFailure(Http::AsyncClient::FailureReason) { | ||
| std::cerr << "Error posting spans to Zipkin" << std::endl; |
Member
There was a problem hiding this comment.
for things like that we should have stats.
Member
There was a problem hiding this comment.
Yep.. its coming in the next commit..
Merged
|
|
||
| void ZipkinReporter::onFailure(Http::AsyncClient::FailureReason) { | ||
| std::cerr << "Error posting spans to Zipkin" << std::endl; | ||
| // TODO: stats |
Contributor
There was a problem hiding this comment.
in case it helps, here's an example of another tracer's stats:
https://github.com/openzipkin/zipkin-finagle#metrics
most use cases are comparing against server stats:
https://github.com/openzipkin/zipkin/blob/master/zipkin-server/README.md#collector
added 7 commits
April 10, 2017 11:33
Conflicts: source/common/CMakeLists.txt source/common/tracing/BUILD source/server/configuration_impl.cc
Member
|
Closing this for now until we get the other PR merged. |
htuch
pushed a commit
that referenced
this pull request
May 3, 2017
This PR adds a Zipkin library to the Envoy code base. Changes made to Envoy to use this library to support Zipkin tracing are in PR #700.
fabolive
changed the title
Merged
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Zipkin tracing. This PR makes Envoy use the code added by PR #692.
cc: @RomanDzhabarov, @adriancole, @mattklein123, @rshriram