Correct usage of iter to comply with general rule#7076
Correct usage of iter to comply with general rule#7076xhzhf wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
In general, if there is no special condition, iter shoule be added at same line with 'for' Signed-off-by: xhzhf <guoyongxhzhf@163.com>
| // the item currently being initialized, so we eschew range-based-for and do this complicated | ||
| // dance to increment the iterator before calling initialize. | ||
| for (auto iter = secondary_init_clusters_.begin(); iter != secondary_init_clusters_.end();) { | ||
| for (auto iter = secondary_init_clusters_.begin(); iter != secondary_init_clusters_.end(); ++iter) { |
There was a problem hiding this comment.
while messing with this, why not:
for (Cluster* cluster : secondary_init_clusters_) {
...
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
CI failures seem vaguely related but I can't figure out how your change could break things.
In the meantime, try merging master?
|
Please merge master to pick up #7090 |
jmarantz
changed the title
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
Bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
3 participants
Signed-off-by: xhzhf guoyongxhzhf@163.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:In general, if there is no special condition, iter shoule be added at same line with 'for'
Risk Level:Low
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]