config: logging LDS file on config failure#7113
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom May 31, 2019
Merged
config: logging LDS file on config failure#7113mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
jmarantz
approved these changes
May 31, 2019
Contributor
|
@snowp for non-googler eyes on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mostly as a follow-on to #6933, it makes it less annoying to diagnose configuration issues when writing new integration tests by
Risk Level: Low (log tweak + test changes)
Testing: existing tests pass (new tests are easier to write)
Docs Changes: n/a
Release Notes: n/a