Skip to content

sds: add ability to reload TLS session ticket keys#7643

Closed
euroelessar wants to merge 1 commit intoenvoyproxy:masterfrom
euroelessar:sds-tickets
Closed

sds: add ability to reload TLS session ticket keys#7643
euroelessar wants to merge 1 commit intoenvoyproxy:masterfrom
euroelessar:sds-tickets

Conversation

@euroelessar
Copy link
Copy Markdown
Contributor

Description: Finish migration of TLS session ticket keys to provider-based API.
Risk Level: Medium
Testing: TODO
Docs Changes: TODO
Release Notes: TODO
Fixes #7397

Signed-off-by: Ruslan Nigmatullin <elessar@dropbox.com>
@euroelessar
Copy link
Copy Markdown
Contributor Author

This is basic functionality implementation, which should work (but never tested yet).
Please verify if it looks like relatively right direction - and I'll add corresponding tests.

@stale
Copy link
Copy Markdown

stale Bot commented Jul 26, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale Bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 26, 2019
@euroelessar
Copy link
Copy Markdown
Contributor Author

@PiotrSikora hi, can you provide a feedback if this pull request is moving into the right direction, please?

@stale stale Bot removed the stale stalebot believes this issue/PR has not been touched recently label Jul 26, 2019
@PiotrSikora
Copy link
Copy Markdown
Contributor

This looks great, thanks!

Could you fix tests and add session ticket keys to the config dump (see: #7365)?

@incfly @JimmyCYJ could you take a pass at this? Thanks!

@JimmyCYJ
Copy link
Copy Markdown
Member

@PiotrSikora I will take a look. Thanks.

@JimmyCYJ
Copy link
Copy Markdown
Member

LGTM, please add tests and fix test failures.

@stale
Copy link
Copy Markdown

stale Bot commented Aug 4, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale Bot added the stale stalebot believes this issue/PR has not been touched recently label Aug 4, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Aug 11, 2019

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale Bot closed this Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish implementation of TLS Session Ticket keys delivery via SDS

3 participants