ssl: require non-empty "cipher_suites" in configuration.#776
Closed
PiotrSikora wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
ssl: require non-empty "cipher_suites" in configuration.#776PiotrSikora wants to merge 1 commit intoenvoyproxy:masterfrom
PiotrSikora wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Member
|
This LGTM, but let's hold because @danielhochman is adding an easy way to add schema tests as part of #715. Once that is in (probably Monday), we can add a schema test for this change. |
Contributor
Author
|
SGTM. |
Contributor
Author
|
Let's put this on hold until we figure out the multi-format configs story (see #773). |
Member
|
OK let's just close for now. We can reopen later. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: iOS CI greps for indicators of liveliness. Sometimes they fail in CI when local runs are ok. This additional step should show us if CI failures are flakes or real. Risk Level: low Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: iOS CI greps for indicators of liveliness. Sometimes they fail in CI when local runs are ok. This additional step should show us if CI failures are flakes or real. Risk Level: low Testing: CI Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #773.