Modify Header Value Match action to pivots on expecting match#810
Merged
Conversation
Contributor
Author
|
@lyft/network-team |
junr03
reviewed
Apr 21, 2017
| will happen if all the headers in the config are present in the request with the same values (or | ||
| based on presence if the ``value`` field is not in the config). | ||
| expect_match | ||
| *(optional, boolean)* Specifies if the action should append a descriptor when it expects a match |
Member
There was a problem hiding this comment.
I think this sentence is redundant and a little confusing. The following two sentences explain very clearly what this value accomplishes.
| )EOF"; | ||
|
|
||
| SetUpTest(json); | ||
| Http::TestHeaderMapImpl header{{"x-header-name", "fake_value"}}; |
Member
There was a problem hiding this comment.
Changing the header value to not_same_value or something similar would make this test more clear, i.e the value is not the same as the descriptor_value, and what is loaded to the descriptors is the descriptor value.
junr03
approved these changes
Apr 21, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
* kotlin: replace Detekt runner script with Bazel rule Signed-off-by: Artur Dryomov <artur.dryomov@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
* kotlin: replace Detekt runner script with Bazel rule Signed-off-by: Artur Dryomov <artur.dryomov@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Previously, unknown path was responded as an internal error as opposed to the fact that it's an 404 with the user input root cause. This fixes the extproc code that way, now that users will be able to know what's wrong with the operation instead of getting the cryptic 500 error. **Related Issues/PRs (if applicable)** Contributes to #810 Closes #724 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Header Value Match action sets a descriptor entry depending on if the expected outcome of comparing request headers to the config is to match or not.