Skeleton of a tracer for AWS X-Ray by marcomagdy · Pull Request #8526 · envoyproxy/envoy

marcomagdy · 2019-10-07T23:01:18Z

Signed-off-by: Marco Magdy mmagdy@gmail.com

Description:
A skeleton tracer to incrementally add support for AWS X-Ray
Risk Level: Low
Testing: unit tests for functionality in util - the rest of files have no business logic to test yet
Docs Changes: N/A
Release Notes: N/A

repokitteh-read-only · 2019-10-07T23:01:23Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #8526 was opened by marcomagdy.

see: more, trace.

jmarantz

lgtm modulo issues of consistency with envoy config practice (config with inlined data) vs AWS sdk practice (config with ref to filename).

I'll let @htuch make the call.

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

marcomagdy · 2019-10-09T23:42:49Z

I've changed the file_name to be a DataSource

htuch

/wait

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

htuch

/wait

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

htuch

Great, LGTM modulo a couple of test asks. The differential fuzzing is optional, but an idea that would make sense long term, in particular if we want to use this elsewhere in Envoy.
/wait

htuch · 2019-10-16T22:35:56Z

+  }
+
+private:
+  std::mt19937 rng_;


FYI, this is totally fine for this PR, but for the real implementation, you should obtain randomness via a Runtime::RandomGenerator (I think from factory context), to allow proper dependency injection and deterministic tests.

I have a reasonable explanation for this. But we'll talk about it in the next PRs

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

marcomagdy · 2019-10-17T20:25:56Z

macos build seems to be stuck.
/retest

repokitteh-read-only · 2019-10-17T20:26:00Z

🐴 hold your horses - no failures detected, yet.

🐱

Caused by: a #8526 (comment) was created by @marcomagdy.

see: more, trace.

htuch · 2019-10-18T18:57:46Z

/azp run

azure-pipelines · 2019-10-18T18:58:04Z

Azure Pipelines successfully started running 3 pipeline(s).

htuch

Thanks! I'd be keen to see the discussed improvements around glob parsing land, but given this is an opt-in extensions and a skeleton, let's merge and continue to iterate.

marcomagdy · 2019-10-21T16:20:22Z

Is there anything I have to do to get this PR merged?
Also, should I squash the commits? or is the person merging this PR expected to do the squashing?

jmarantz · 2019-10-21T18:35:27Z

Don't squash (or force-push); that will happen on merge. Probably we need to re-execute the MacOS tests which have most likely flaked; I'll do that now.

jmarantz · 2019-10-21T18:35:42Z

/azp run envoy-macos

azure-pipelines · 2019-10-21T18:35:51Z

Azure Pipelines successfully started running 1 pipeline(s).

A skeleton tracer to incrementally add support for AWS X-Ray Risk Level: Low Testing: unit tests for functionality in util - the rest of files have no business logic to test yet Signed-off-by: Marco Magdy <mmagdy@gmail.com>

jmarantz reviewed Oct 8, 2019

View reviewed changes

Comment thread source/extensions/tracers/xray/util.cc Outdated

Comment thread test/extensions/tracers/xray/util_test.cc Outdated

Comment thread source/extensions/tracers/xray/util.h Outdated

Comment thread source/extensions/tracers/xray/xray_tracer_impl.cc Outdated

htuch reviewed Oct 8, 2019

View reviewed changes

Comment thread api/envoy/config/trace/v2/trace.proto Outdated

jmarantz reviewed Oct 8, 2019

View reviewed changes

Comment thread test/extensions/tracers/xray/util_test.cc Outdated

Comment thread source/extensions/tracers/xray/util.h Outdated

Comment thread source/extensions/tracers/xray/util.cc Outdated

jmarantz assigned jmarantz and htuch Oct 9, 2019

jmarantz previously approved these changes Oct 9, 2019

View reviewed changes

marcomagdy dismissed jmarantz’s stale review via 05db3c4 October 9, 2019 23:12

marcomagdy added 8 commits October 9, 2019 23:15

Skeleton of a tracer for AWS X-Ray

6b85164

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

Fix proto format

bbadcb4

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

Not sure why gcc did not catch all this

b17c374

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

Fix clang-tidy errors

fa410cc

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

review feedback

7be86ba

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

Add a TODO and remove blank line

7464153

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

more test cases for wildcard matching

276b079

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

Use DataSource instead of string filename

7ad797c

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

marcomagdy force-pushed the xray branch from 05db3c4 to 7ad797c Compare October 9, 2019 23:41

htuch suggested changes Oct 10, 2019

View reviewed changes

repokitteh-read-only Bot added the waiting label Oct 10, 2019

Add tests for config loading

ab92985

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

repokitteh-read-only Bot removed the waiting label Oct 10, 2019

marcomagdy added 4 commits October 10, 2019 23:15

Address feedback

553166a

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

clang tidy stuff

49323b5

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

crossing my fingers

f21aa1c

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

Docs - comment out references to xray

d4242f5

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

marcomagdy requested a review from htuch October 11, 2019 18:45

htuch suggested changes Oct 13, 2019

View reviewed changes

Comment thread source/extensions/tracers/xray/util.cc Outdated

Comment thread source/extensions/tracers/xray/config.cc Outdated

repokitteh-read-only Bot added the waiting label Oct 13, 2019

Fuzz test the wildcard matcher

e87a0e0

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

repokitteh-read-only Bot removed the waiting label Oct 14, 2019

Use DataSource API

4abd180

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

marcomagdy force-pushed the xray branch from a579c88 to 4abd180 Compare October 14, 2019 20:54

lavignes reviewed Oct 14, 2019

View reviewed changes

Comment thread source/extensions/tracers/xray/config.cc Outdated

Updated error message

c081d68

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

marcomagdy requested a review from htuch October 15, 2019 02:19

Added comments to the wildcard matching function

2a5f7e2

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

htuch suggested changes Oct 16, 2019

View reviewed changes

repokitteh-read-only Bot added the waiting label Oct 16, 2019

more tests

b16f0fb

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

repokitteh-read-only Bot removed the waiting label Oct 16, 2019

Added TODO

5b9cb89

Signed-off-by: Marco Magdy <mmagdy@gmail.com>

htuch approved these changes Oct 18, 2019

View reviewed changes

htuch merged commit f68368f into envoyproxy:master Oct 22, 2019

lavignes mentioned this pull request Oct 23, 2019

Support Dynamic AWS X-Ray sampling configuration aws/aws-app-mesh-roadmap#95

Open

Conversation

marcomagdy commented Oct 7, 2019

Uh oh!

repokitteh-read-only Bot commented Oct 7, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmarantz left a comment

Choose a reason for hiding this comment

Uh oh!

marcomagdy commented Oct 9, 2019

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

htuch Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

marcomagdy Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcomagdy commented Oct 17, 2019

Uh oh!

repokitteh-read-only Bot commented Oct 17, 2019

Uh oh!

htuch commented Oct 18, 2019

Uh oh!

azure-pipelines Bot commented Oct 18, 2019

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

marcomagdy commented Oct 21, 2019

Uh oh!

jmarantz commented Oct 21, 2019

Uh oh!

jmarantz commented Oct 21, 2019

Uh oh!

azure-pipelines Bot commented Oct 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants