build/test: some fixups for the google import.#859
Merged
Conversation
* Fix TestEnvironment::runfilesDirectory() to use TEST_RUNDIR, rather than the other way around. * Remove use of diff -Z in hotrestart_test, since it's not needed and isn't supported by all versions of diff. * Add license directives to all files.
Member
|
Can we enforce "licenses(["notice"]) # Apache 2" in check/fix format? I fear this will end up getting dropped occasionally. |
mattklein123
approved these changes
Apr 28, 2017
mattklein123
approved these changes
Apr 28, 2017
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Since the next EG v1.5 will be our target version that AIGW v0.3 will be based on, there's no reason to keep it at the moment. This is mainly to unblock the incoming feature patches that will rely on v1.5 feature, such as #823. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TestEnvironment::runfilesDirectory() to use TEST_RUNDIR, rather
than the other way around.
Remove use of diff -Z in hotrestart_test, since it's not needed and
isn't supported by all versions of diff.
Add license directives to all files.