ci envoy-filter-example#902
Merged
Merged
Conversation
htuch
approved these changes
May 5, 2017
| # This is the hash on https://github.com/htuch/envoy-consumer.git we pin to. | ||
| (cd "${ENVOY_CONSUMER_SRCDIR}" && git checkout 94e11fa753a1e787c82cccaec642eda5e5b61ed8) | ||
| # This is the hash on https://github.com/lyft/envoy-filter-example.git we pin to. | ||
| # TODO(hennna): Point to updated hash. |
Contributor
Author
There was a problem hiding this comment.
I mean the updated hash after envoyproxy/envoy-filter-example#1 is merged.
Member
|
Thanks for doing this, one fewer items on my (too long) TODO list :) |
mattklein123
approved these changes
May 6, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: add individual stats for some 4xx codes of interest at Lyft. In the future, like other stats we can have this be configurable. Risk Level: low Testing: local Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: add individual stats for some 4xx codes of interest at Lyft. In the future, like other stats we can have this be configurable. Risk Level: low Testing: local Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Since log time ago (i think v0.2.), there has been a limitation on k8s Serice as a target by AIServiceBackend. The detailed context is described in #902. However, we haven't had any CRD CEL validation that enforces the limitation, hence there has been a lot of users encountering the limitation that results in *very* hard-to-debug errors. e.g. #1169 kserve/kserve#4595 (comment) Since resolving #902 takes a relatively large amount of efforts (needs change in EG) as well as using k8s service as a target is out of our primary scope, this adds a CEL validation to save everyone's time. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The envoy filter example now lives at lyft/envoy-filter-example rather than htuch/envoy-consumer. This PR updates the corresponding setup changes.