Update Wasm VM code to the latest from envoy-wasm.#9077
Conversation
jplevyak
commented
Nov 19, 2019
jplevyak
commented
- make v8 cloneable
- add VM stats and debug logging.
- make v8 less build environmentally sensitive/hermetic.
- make v8 cloneable - add VM stats and debug logging. - make v8 less build environmentally sensitive/hermetic. Signed-off-by: John Plevyak <jplevyak@gmail.com>
|
|
||
| # Build wee8. | ||
| third_party/depot_tools/gn gen out/wee8 --args="$$WEE8_BUILD_ARGS" | ||
| if [[ `uname` == "Darwin" ]]; then |
There was a problem hiding this comment.
Isn't third_party/depot_tools/gn the script supposed to do this? cc @PiotrSikora
There was a problem hiding this comment.
It is, but for some reason it doesn't work on @jplevyak's box.
There was a problem hiding this comment.
That script also gropes around in the environment in a very non-hygienic way in order to do this very simple thing, which is probably why it doesn't work on my dev box.
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
At this point in development, I think it would make sense to push those changes separately, instead of doing code dumps, to preserve some context in the commit history... at the very least, please include references to the PRs that being upstreamed here.
|
|
||
| # Build wee8. | ||
| third_party/depot_tools/gn gen out/wee8 --args="$$WEE8_BUILD_ARGS" | ||
| if [[ `uname` == "Darwin" ]]; then |
There was a problem hiding this comment.
It is, but for some reason it doesn't work on @jplevyak's box.
Signed-off-by: John Plevyak <jplevyak@gmail.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
Bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
Bot
removed
the
stale
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
Bot
added
the
stale
|
This has been replaced with #9259 |
3 participants
