docs/best_practices/edge: fix use_proxy_proto location#9082
Merged
junr03 merged 1 commit intoenvoyproxy:masterfrom Nov 20, 2019
Dominik-K:docs/best_practices/edge/use_proxy_proto_fixed
Merged
docs/best_practices/edge: fix use_proxy_proto location#9082junr03 merged 1 commit intoenvoyproxy:masterfrom Dominik-K:docs/best_practices/edge/use_proxy_proto_fixed
use_proxy_proto location#9082junr03 merged 1 commit intoenvoyproxy:masterfrom
Dominik-K:docs/best_practices/edge/use_proxy_proto_fixed
Conversation
`use_proxy_proto` is part of the `listener.FilterChain` (not `HttpConnectionManager`) https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/listener/listener.proto#listener-filterchain Signed-off-by: Dominik <dominik-k@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_proxy_protois part of thelistener.FilterChain(notHttpConnectionManager)https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/listener/listener.proto#listener-filterchain
Signed-off-by: Dominik dominik-k@mailbox.org
Risk Level: None
Testing: Manually tested with
envoyproxy/envoy-alpine:v1.12.1(Docker image)Docs Changes: see description
Release Notes: docs: corrected use of
use_proxy_protoin edge-proxy best-practice exampleFix for #8001
(Sorry for the doubled creation of this PR. Did it wrong (on #9079) with trying to fix to add my DCO. Sad that Github doesn't do it. But there's a Github feature-request for automated DCO signoff, but with just 3 votes, yet.)