api: include v1alpha1 in proto_sync.py#9175
Merged
htuch merged 4 commits intoenvoyproxy:masterfrom Dec 10, 2019
Merged
Conversation
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Member
|
@derekargueta I think we do need to have the tools do this, since these APIs might gain new fields before we do the v3 cut. I think it's fairly easy to do, check out |
Member
Author
|
I didn't want to add one-off logic but since we already handling vNalphaN for v2 in |
Signed-off-by: Derek Argueta <dereka@pinterest.com>
Member
Author
Member
|
@derekargueta ah yeah. So, I think your tool changes make sense, but then we shouldn't have the actual protos in v3alpha. We're only upgrading packages that have either had a breaking change or transitively depend on a package that has been upgraded. We basically have a DAG of versions. |
Signed-off-by: Derek Argueta <dereka@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Follow-up to #8133, these likely escaped detection since they're versioned "v1alpha1" and the cloning script only searches for the last major version. This should be a one-off to get these caught up so I'm not modifying the tooling to accommodate these.
Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta dereka@pinterest.com