Proxy-WASM ABI Part 1.#9257
Conversation
Signed-off-by: John Plevyak <jplevyak@gmail.com>
htuch
left a comment
There was a problem hiding this comment.
Thanks for the split. I'd like to see if we can understand this with a context free Envoy developers hat on as a first step.
Signed-off-by: John Plevyak <jplevyak@gmail.com>
|
Added Doxygen comments. PTAL |
htuch
left a comment
There was a problem hiding this comment.
Thanks for the Doxygen. A few followup questions.
/wait
Signed-off-by: John Plevyak <jplevyak@gmail.com>
mattklein123
left a comment
There was a problem hiding this comment.
Per my other comment, IMO we need a high level design doc to make sure we have a shared understanding. Thank you!
/wait
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
|
Where would be the best place for the design docs? envoy/api/wasm/v0/* or envoy/docs/root/wasm ? |
I commented elsewhere on where I would like to see the docs (I can't remember where, in one of these PRs). Please also check your email. In the short term I really want to see a 1-2 page overview which can be in the form of a gdoc, before we merge the final docs in. |
|
Putting this into waiting until we finalize the overview doc that is floating around. That will help make reviews go much faster. /wait |
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
mattklein123
left a comment
There was a problem hiding this comment.
LGTM modulo file moves. Thank you!
/wait
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
htuch
left a comment
There was a problem hiding this comment.
LGTM (with the file move and addressing last nit thread).
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
htuch
left a comment
There was a problem hiding this comment.
LGTM, needs format fix, thanks!
Signed-off-by: John Plevyak <jplevyak@gmail.com>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Proxy-WASM ABI Part 1.
Risk Level: Low
Testing: N/A
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]