Skip to content

WiP http: add lazy map for eliminating O(n) header operations. #9261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmarantz wants to merge 18 commits into from
Closed

WiP http: add lazy map for eliminating O(n) header operations. #9261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
759e22e
patch in PR 9114.
jmarantz Dec 2, 2019
1d6f528
Add lazy map implementation and make the speed tests show its impact …
jmarantz Dec 2, 2019
be74058
Removed inline headers from the map.
jmarantz Dec 2, 2019
1dd454c
add ifdefs to selecft between multi-map mode and flat-hash-map.
jmarantz Dec 2, 2019
61912d2
unpatch 9114
jmarantz Dec 6, 2019
9fbf450
Merge branch 'master' into header-lazy-map
jmarantz Dec 7, 2019
21c7df8
format
jmarantz Dec 7, 2019
25d96ef
Only create a map if there's more than a certain number of headers. T…
jmarantz Dec 7, 2019
e4d228d
add absl::btree variant; not working yet
jmarantz Dec 8, 2019
1c3e0dd
Merge branch 'master' into header-lazy-map
jmarantz Dec 8, 2019
b88bdce
experiment with other absl containers for headers.
jmarantz Dec 19, 2019
9bcb78f
Merge branch 'master' into header-lazy-map
jmarantz Jan 15, 2020
c01320c
get the SLIST variant working, sort of (modulo setCopy behavior).
jmarantz Jan 15, 2020
bd27ddf
Merge branch 'master' into header-lazy-map
jmarantz Jan 15, 2020
764ce9b
switch away from SLIST as there are some semantic diffs currently tha…
jmarantz Jan 15, 2020
86cab1e
Fix always-false warning.
jmarantz Jan 15, 2020
5026a19
Use a define for MAP_SIZE_THRESHOLD to avoid compile always-false war…
jmarantz Jan 16, 2020
7f3f3c5
Make SLIST behave correctly.
jmarantz Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bazel/envoy_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,10 @@ def envoy_cc_library(
deps = deps + [envoy_external_dep_path(dep) for dep in external_deps] + [
repository + "//include/envoy/common:base_includes",
repository + "//source/common/common:fmt_lib",
envoy_external_dep_path("abseil_btree"),
envoy_external_dep_path("abseil_flat_hash_map"),
envoy_external_dep_path("abseil_flat_hash_set"),
envoy_external_dep_path("abseil_inlined_vector"),
envoy_external_dep_path("abseil_strings"),
envoy_external_dep_path("spdlog"),
envoy_external_dep_path("fmtlib"),
Expand Down
4 changes: 4 additions & 0 deletions bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,10 @@ def _com_google_absl():
name = "absl-base",
actual = "@com_google_absl//absl/base",
)
native.bind(
name = "abseil_btree",
actual = "@com_google_absl//absl/container:btree",
)
native.bind(
name = "abseil_flat_hash_map",
actual = "@com_google_absl//absl/container:flat_hash_map",
Expand Down
3 changes: 2 additions & 1 deletion include/envoy/http/header_map.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,8 @@ class HeaderMap {
virtual uint64_t byteSize() const PURE;

/**
* Get a header by key.
* Get the first instance of a header by key. Subsequent entries for the same key are ignored.
*
* @param key supplies the header key.
* @return the header entry if it exists otherwise nullptr.
*/
Expand Down
Loading