tooling: flags fixups#9312
Merged
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
(windows CI breakage is known and unrelated) |
junr03
previously approved these changes
Dec 11, 2019
junr03
dismissed
their stale review
whoops I only saw the second commit's diff. Need to review all.
junr03
reviewed
Dec 11, 2019
Member
junr03
left a comment
junr03
left a comment
There was a problem hiding this comment.
a couple comments. Thanks for making this process more and more sustainable :)
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
lizan
added a commit
to lizan/envoy
that referenced
this pull request
Dec 14, 2019
This reverts commit 3703789. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan
added a commit
to lizan/envoy
that referenced
this pull request
Dec 15, 2019
This reverts commit e8e2192. Signed-off-by: Lizan Zhou <lizan@tetrate.io>
prakhag1
pushed a commit
to prakhag1/envoy
that referenced
this pull request
Jan 3, 2020
Changing runtime ASSERTs to ensure that all runtime guards are registered as true by default, or in the "special case" section (documented to be used with care, tracking issues etc.) Changing governance to note we should look at that section when we cut releases. Changing flags script to file code removal after guards have been true for 6 months. Risk Level: Meduim (if folks are using the upstream naming paradigm they'll fail asserts) Testing: existing tests Docs Changes: governance update Release Notes: n/a Fixes envoyproxy#8992 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Prakhar <prakhar_au@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing runtime ASSERTs to ensure that all runtime guards are registered as true by default, or in the "special case" section (documented to be used with care, tracking issues etc.)
Changing governance to note we should look at that section when we cut releases.
Changing flags script to file code removal after guards have been true for 6 months.
Risk Level: Meduim (if folks are using the upstream naming paradigm they'll fail asserts)
Testing: existing tests
Docs Changes: governance update
Release Notes: n/a
Fixes #8992