Document incremental xDS semantics about resources that do not exist.#9317
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Dec 12, 2019
Merged
Conversation
Signed-off-by: Mark D. Roth <roth@google.com>
Merged
htuch
suggested changes
Dec 11, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, appreciate the clarification. I assume Envoy has to handle this correctly due to the way on-demand VHDS will work (@dmitri-d @brian-avery)
/wait
| When a resource subscribed to by a client does not exist, the server will send a :ref:`Resource | ||
| <envoy_api_msg_Resource>` whose :ref:`name <envoy_api_field_Resource.name>` field matches the | ||
| name that the client subscribed to and whose :ref:`resource <envoy_api_field_Resource.resource>` | ||
| field is unset. |
Member
There was a problem hiding this comment.
The motivation here is to avoid having to wait on a timeout (which is basically what happens during warming in Envoy today). Can you add this to the docs?
Signed-off-by: Mark D. Roth <roth@google.com>
prakhag1
pushed a commit
to prakhag1/envoy
that referenced
this pull request
Jan 3, 2020
…envoyproxy#9317) Document incremental xDS semantics about resources that do not exist. Risk Level: Low Testing: N/A Docs Changes: Included in PR Release Notes: N/A This attempts to clarify the incremental xDS protocol semantics, as per discussion in envoyproxy#7415 Signed-off-by: Mark D. Roth <roth@google.com> Signed-off-by: Prakhar <prakhar_au@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Document incremental xDS semantics about resources that do not exist.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
This attempts to clarify the incremental xDS protocol semantics, as per discussion in #7415 (comment). CC @htuch