ci: Move to GCC 5.4 (Xenial default) for prebuilts#946
Conversation
This is part 1 of a change to switch us over to a GCC 5.4 so that we get a thread safe std::string implementation. Will follow up with another commit with CI and doc changes.
| apt-get install -y g++-4.9 | ||
| clang-format-3.6 bc libtool automake zip time golang g++ gdb strace | ||
| # clang head (currently 5.0) | ||
| wget -O - http://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - |
There was a problem hiding this comment.
we could save some time by doing all the repo adding and coalescing the apt-get update
There was a problem hiding this comment.
So I tried this, but wget isn't installed by default. Sigh.
| # GCC 4.9 for everything. | ||
| export CC=gcc-4.9 | ||
| export CXX=g++-4.9 | ||
|
|
There was a problem hiding this comment.
Is it worth invoking gcc here for a version check to ensure we have the version we think we do?
There was a problem hiding this comment.
Yeah might as well. I will add an echo that we can look at in the job. I actually think default GCC in Xenial might be 5.3.
There was a problem hiding this comment.
It's probably still good to see CC=gcc etc. just to ensure that we don't accidentally get defaulted into clang one day by Bazel magic.
|
@htuch updated |
| # GCC for everything. | ||
| export CC=gcc | ||
| export CXX=g++ | ||
| g++ --version |
There was a problem hiding this comment.
Could also do a `[ $(g++ --version) == "g++ ... 5.3.blah" ] || (echo "Unexpected compiler version"; exit 1)
There was a problem hiding this comment.
This requires a bunch of sed stuff, I can try to figure this out.
There was a problem hiding this comment.
Just compare the exact string - this is only used in the container where that will be stable.
|
Nit: maybe use CXX when invoking the compiler.. |
|
@htuch updated |
This is part 1 of a change to switch us over to a GCC 5.4 so that we get a thread safe std::string implementation. Will follow up with another commit with CI and doc changes.
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of proxy This PR will be merged automatically once checks are successful. ```release-note none ```
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
This fixes test miscompilations on some clang 6.0 installations. Particularly issue envoyproxy#946. Defines tested by tcmalloc.h where totally wrong defines. configure actually puts defines of HAVE_DECL_FOOBAR kind in config.h. Which is what we're using now.
**Description** This adds an example usage of ClientTrafficPolicy which is every will have to configure most cases. **Related Issues/PRs (if applicable)** Closes #828 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
4 participants
This is part 1 of a change to switch us over to a GCC 5.4 so that
we get a thread safe std::string implementation. Will follow up
with another commit with CI and doc changes.