Restrict documentation line width#9758
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jan 21, 2020
lucperkins:lperkins/no-max-width
Merged
Restrict documentation line width#9758mattklein123 merged 1 commit intoenvoyproxy:masterfrom lucperkins:lperkins/no-max-width
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
lucperkins:lperkins/no-max-width
Conversation
Signed-off-by: lucperkins <lucperkins@gmail.com>
mattklein123
approved these changes
Jan 21, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Fine with me. I was ambivalent about the original change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #7993 made a CSS change that makes documentation content cover the entire page width. I take this to be a regression. Amongst technical writers, there's a broad consensus that long line lengths beyond about 3 alphabets produce undue strain on the eye (see here, here, and here, amongst others). This PR undoes those changes and re-introduces the 800px width.