Remove MAX_STREAMS check on client side connection pool. (#963)#986
Closed
jwfang wants to merge 1 commit intoenvoyproxy:masterfrom
jwfang:issue963-1
Closed
Remove MAX_STREAMS check on client side connection pool. (#963)#986jwfang wants to merge 1 commit intoenvoyproxy:masterfrom jwfang:issue963-1
jwfang wants to merge 1 commit intoenvoyproxy:masterfrom
jwfang:issue963-1
Conversation
The reason for this is that we already have protection via circuit breakers. There is no point in having additional protection (other than potentially for push, which we don't support currently, and can deal with later). If we overflow the other side, the code will correctly handle the REFUSED_STREAM reset that happens.
Contributor
Author
|
background and discussion is here: #981 for the unit test, it seems the whole TEST_F(Http2ConnPoolImplTest, MaxRequests) is for |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
At the moment, `continueRequest()` and `continueResponse()` are not yet wired up. While we plan to implement that in the very near future (next week or so), we do not have plans to add these other "async" operations at the moment. Removing them from the public interface until we're ready to implement them. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
At the moment, `continueRequest()` and `continueResponse()` are not yet wired up. While we plan to implement that in the very near future (next week or so), we do not have plans to add these other "async" operations at the moment. Removing them from the public interface until we're ready to implement them. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This fixes the naming for the additional label configuration from `metricsRequestHeaderLabelMapping` to `metricsRequestHeaderLabels`, and fixed a bug in helm. Additionally, this adds an end to end test case to verify this flag working. **Related Issues/PRs (if applicable)** Follow up on #981 Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this is that we already have protection via circuit breakers.
There is no point in having additional protection (other than potentially
for push, which we don't support currently, and can deal with later). If we
overflow the other side, the code will correctly handle the REFUSED_STREAM
reset that happens.