stat sinks/tracers: use new style names#9970
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Feb 12, 2020
Merged
Conversation
Modifies the well-known-names of the built-in stat sinks and tracers to use the same name as the extension build system. Risk Level: low, previous name is still accepted Testing: existing tests + deprecated tests for old names Docs Changes: updated names Release Notes: updated Deprecated: old names are logged as deprecated Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
No rush on this one. |
mattklein123
requested changes
Feb 11, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Epic! Just small alpha order nit.
/wait
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the well-known-names of the built-in stat sinks and
tracers to use the same name as the extension build system.
(Repeats #9921 for two new factory types.)
Risk Level: low, previous name is still accepted
Testing: existing tests + deprecated tests for old names
Docs Changes: updated names
Release Notes: updated
Deprecated: old names are logged as deprecated
Signed-off-by: Stephan Zuercher zuercher@gmail.com