translator: add name

[zirain]

1. add Name on

   gateway/internal/xds/translator/translator.go

   Line 27 in 773bdfb

   type Translator struct {

2. use namespace/name as fortmat

cc @arkodg

[arkodg]

+1, we should use / everywhere including in the helpers here

gateway/internal/gatewayapi/helpers.go

Line 388 in ab7aed6

func irStringKey(gatewayNs, gatewayName string) string {

this is a breaking change and should be added to the release notes for v0.5.0

[arkodg]

there is a issue with replacing - to / everywhere when building out internal names, this will not work in the infra layer that uses the IR name (<namespace>-<name> to <namespace>/<name>) to create k8s deployment names

gateway/internal/infrastructure/kubernetes/proxy/resource_provider.go

Line 180 in 609949d

Name: ExpectedResourceHashedName(r.infra.Name),

[zirain]

1. strings.Replace("", "/", "-", -1)
2. I'm not a big fan of put all gateway in a single namespace.

[zirain]

BTW, is this a block for #1629?

[arkodg]

BTW, is this a block for #1629?

non blocking, but related imo, approved the PR

[arkodg]

Highlighting the name collision issue and potential solution in more detail
Issue

• EG accepts Gateway resources from multiple namespaces and generates/deploys K8s resources such as Deployment mapping to each of these Gateways in the system namespace where EG is running

• EG currently creates internal IR names using this logic = <GatewayNamespace>-<GatewayName>
  The issue here can be highlighted with this example

  • Gateway1: NS1 = foo Name1 = bar-baz IRName1 = foo-bar-baz
  • Gateway2: NS2 = foo-bar Name2 = baz IRName2 = foo-bar-baz

• Above example shows that two different Gateways in different namespaces can end up creating the same IR Name which will cause a resource creation collision since they will created in the same namespace (system namespace / envoy-gateway-system)

Potential Solution

• Use a separator that cannot be part of the Gateway name such as / when generating IR Names
• When generating K8s resource names from IR Names, replace / with - as the separator, but also append the unique hash based on the IR Name ensuring uniqueness
• PoC in Use / to create internal IR names instead of - #1681

ptal @envoyproxy/gateway-maintainers