Skip to content

Infra Manager updates Service failed and trigger svc/deployment wrongly #746

@Xunzhuo

Description

@Xunzhuo

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

Infra Manager updates Service Failed and Wrongly

  • Update Service Failed:

企业微信截图_ef8a2076-e871-4aa0-8b50-3e17f506b6cf

It can be reproduced after update Gateway CR.

  • Update Service Wrongly:

We should not simply use deep copy to compare if svc has changed: https://github.com/envoyproxy/gateway/blob/main/internal/infrastructure/kubernetes/service.go#L95

We should just compare a couple of specific vars. (Some vars in svc spec are fullfiled by k8s itself).

When restarting envoy gateway, without anychanges to gateway CR, it will be updated wrongly.

Metadata

Metadata

Assignees

Labels

area/infra-mgrIssues related to the provisioner used for provisioning the managed Envoy Proxy fleet.kind/bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions