Updates Design Doc#111
Merged
danehans merged 6 commits intoenvoyproxy:mainfrom Jun 27, 2022
Merged
Conversation
danehans
force-pushed
the
design_doc_update
branch
2 times, most recently
from
1f1451d to
959d938
Compare
Merged
danehans
force-pushed
the
design_doc_update
branch
from
959d938 to
ef92de7
Compare
Signed-off-by: danehans <daneyonhansen@gmail.com>
danehans
force-pushed
the
design_doc_update
branch
from
ef92de7 to
be110f2
Compare
youngnick
previously approved these changes
Jun 21, 2022
Contributor
youngnick
left a comment
youngnick
left a comment
There was a problem hiding this comment.
Thanks for this update, I think it does a great job of recording what we've decided.
| will provide. | ||
|
|
||
| The draft for this document is [here](https://docs.google.com/document/d/1riyTPPYuvNzIhBdrAX8dpfxTmcobWZDSYTTB5NeybuY/edit) | ||
| * Envoy Gateway will consume one [GatewayClass][gc] by comparing its configured controller name with |
Contributor
There was a problem hiding this comment.
I really appreciate the specificity in this section, nice work.
arkodg
reviewed
Jun 21, 2022
arkodg
reviewed
Jun 21, 2022
danehans
force-pushed
the
design_doc_update
branch
2 times, most recently
from
58b3d68 to
2590b76
Compare
Signed-off-by: danehans <daneyonhansen@gmail.com>
danehans
force-pushed
the
design_doc_update
branch
2 times, most recently
from
a424d26 to
553ec65
Compare
Signed-off-by: danehans <daneyonhansen@gmail.com>
danehans
force-pushed
the
design_doc_update
branch
from
553ec65 to
8040be0
Compare
arkodg
previously approved these changes
Jun 23, 2022
alexgervais
reviewed
Jun 23, 2022
Signed-off-by: danehans <daneyonhansen@gmail.com>
skriss
reviewed
Jun 23, 2022
alexgervais
previously approved these changes
Jun 23, 2022
kflynn
reviewed
Jun 23, 2022
Signed-off-by: danehans <daneyonhansen@gmail.com>
arkodg
previously approved these changes
Jun 24, 2022
arkodg
reviewed
Jun 24, 2022
Signed-off-by: danehans <daneyonhansen@gmail.com>
arkodg
approved these changes
Jun 24, 2022
This was referenced Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#97 has fostered great discussion about EGs design, deployment, terminology, etc. Additionally, #95 attempts to define EGs runtime configuration API. This PR updates the design doc based on the above issue and PR.
Signed-off-by: danehans daneyonhansen@gmail.com