Adds Config API#122
Conversation
There was a problem hiding this comment.
the tools should follow the convention highlighted here https://github.com/envoyproxy/gateway/blob/main/tools/docker/Dockerfile
There was a problem hiding this comment.
we expect the user to either have the tools installed locally or run the make target inside a container
There was a problem hiding this comment.
Based on this vote, the community has decided to focus on using the "local dev" approach and no longer support the MAKE_IN_DOCKER approach. @LukeShu is assigned #124 and will have a PR submitted to transition the current Docker-based linters. With that said, IMHO the targets added by this PR should be acceptable.
danehans
force-pushed
the
issue_51_impl
branch
2 times, most recently
from
f4a66d6 to
3461c2e
Compare
youngnick
left a comment
youngnick
left a comment
There was a problem hiding this comment.
I think the structs that are the core here look great to get us started.
Perhaps in a followup, we could consider putting a .gitattributes into the root, so that the generated files are shown as collapsed automatically in the Github UI?
Gateway API does this in https://github.com/kubernetes-sigs/gateway-api/blob/main/.gitattributes .
youngnick
left a comment
youngnick
left a comment
There was a problem hiding this comment.
Oops, meant to approve. The other comment is non-blocking.
danehans
force-pushed
the
issue_51_impl
branch
3 times, most recently
from
afe03b7 to
ccf7764
Compare
Signed-off-by: danehans <daneyonhansen@gmail.com>
4 participants
Adds Config API and tooling in support of #95.
xref: #29
Signed-off-by: danehans daneyonhansen@gmail.com