Xds translator#123
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Jul 8, 2022
Merged
Conversation
Contributor
Author
|
hitting a codespell error https://github.com/envoyproxy/gateway/runs/7103153542?check_suite_focus=true that should be fixed in #125 |
arkodg
pushed a commit
to arkodg/gateway
that referenced
this pull request
Jun 29, 2022
relates to envoyproxy#123 (comment) Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
added a commit
that referenced
this pull request
Jun 29, 2022
* fix go mod * reran `go mod tidy` / `go mod vendor` * fix spellings that was causing codespell to complain * run ci for md file changes relates to #123 (comment) Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Contributor
youngnick
previously approved these changes
Jul 7, 2022
Contributor
youngnick
left a comment
youngnick
left a comment
There was a problem hiding this comment.
This LGTM. I like the test structure, it seems like it should be easy to do TDD with.
Relates to envoyproxy#39 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Contributor
Author
|
thanks for the review @youngnick , repushed to fix the |
danehans
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #39
Referenced most of the code from @cpakulski's work in a similar project