chore: implement make target for multi arch image build#139
Merged
Conversation
Signed-off-by: Loong Dai <loong.dai@intel.com>
Signed-off-by: Loong Dai <loong.dai@intel.com>
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 5 5
=========================================
Hits 5 5 Continue to review full report at Codecov.
|
arkodg
reviewed
Jul 6, 2022
arkodg
reviewed
Jul 6, 2022
Signed-off-by: Loong Dai <loong.dai@intel.com>
Signed-off-by: Loong Dai <loong.dai@intel.com>
arkodg
approved these changes
Jul 7, 2022
Contributor
arkodg
left a comment
arkodg
left a comment
There was a problem hiding this comment.
LGTM thanks !
Sidenote - would have been great if --load worked with buildx/docker to load the manifest list into docker but it doesnt
docker/buildx#59
arkodg
reviewed
Jul 8, 2022
|
|
||
| .PHONY: image.multiarch.setup | ||
| image.multiarch.setup: image.verify image.multiarch.verify image.multiarch.emulate | ||
| @docker run --rm --privileged tonistiigi/binfmt --install all # Install QEMU emulators |
Member
Author
There was a problem hiding this comment.
I miss it, post anther PR to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #138
Signed-off-by: Loong Dai loong.dai@intel.com