Adds GatewayClass Status Support#150
Conversation
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 53.08% 51.50% -1.59%
==========================================
Files 12 15 +3
Lines 486 666 +180
==========================================
+ Hits 258 343 +85
- Misses 210 299 +89
- Partials 18 24 +6
Continue to review full report at Codecov.
|
dba3598 to
bfb5965
Compare
youngnick
left a comment
There was a problem hiding this comment.
This LGTM with one future request about ObservedGeneration - it's critical for Condition consumers to be able to be sure they're seeing the correct version of the status.
There was a problem hiding this comment.
We should probably have a TODO here to pass the Generation as well, so we can set ObservedGeneration. Not blocking for this PR though.
skriss
left a comment
There was a problem hiding this comment.
Code LGTM. My one comment is that as we're reusing code from other projects (which I'm in favor of BTW), we should make sure we're doing some attribution/not falling afoul of licensing requirements by reusing that work. I'm not sure what the best approach to doing this is, since I expect we'll all be doing a fair amount of reuse -- perhaps we can add some documentation at the repo level indicating the projects that we're reusing code from and including whatever license info is required, rather than doing it on a file-by-file basis.
a86d789 to
f481318
Compare
|
@skriss @youngnick commit |
|
@danehans my hope is that we can do something like #92 (comment) to avoid needing to do this per file, but until we resolve that, I think what you have works. The one other thing I would add is for any files that were not copied verbatim, adding some text indicating they've been modified from the original to satisfy https://github.com/envoyproxy/gateway/blob/main/LICENSE#L97-L98. |
3dff7bc to
a929339
Compare
|
@skriss @youngnick I've updated the relevant src files with a Contour attribution. I think this is acceptable until #92 (comment) is resolved, PTAL. |
skriss
left a comment
There was a problem hiding this comment.
LGTM pending a little merge conflict.
Signed-off-by: danehans <daneyonhansen@gmail.com>
Fixes #147
Signed-off-by: danehans daneyonhansen@gmail.com