Skip to content

Updates Integration Tests#196

Merged
danehans merged 1 commit intoenvoyproxy:mainfrom
danehans:resource_table_fixes
Aug 11, 2022
Merged

Updates Integration Tests#196
danehans merged 1 commit intoenvoyproxy:mainfrom
danehans:resource_table_fixes

Conversation

@danehans
Copy link
Copy Markdown
Contributor

@danehans danehans commented Aug 8, 2022

Adds ResourceTable coverage to the Kubernetes provider integration tests

Requires: #194

@danehans danehans requested a review from a team as a code owner August 8, 2022 21:39
@danehans danehans added the provider/kubernetes Issues related to the Kubernetes provider label Aug 8, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 8, 2022

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.80%. Comparing base (deaef4e) to head (1493668).
⚠️ Report is 4313 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/helpers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   60.00%   61.80%   +1.79%     
==========================================
  Files          25       25              
  Lines        2098     2100       +2     
==========================================
+ Hits         1259     1298      +39     
+ Misses        759      720      -39     
- Partials       80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: danehans <daneyonhansen@gmail.com>
@LukeShu
Copy link
Copy Markdown
Contributor

LukeShu commented Aug 10, 2022

On the topic of gatewayapi/helpers.go coverage going down, do we want to add -coverpkg=./... so that it doesn't matter which package the tests belong to when counting coverage?

Copy link
Copy Markdown
Contributor

@LukeShu LukeShu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danehans
Copy link
Copy Markdown
Contributor Author

On the topic of gatewayapi/helpers.go coverage going down, do we want to add -coverpkg=./... so that it doesn't matter which package the tests belong to when counting coverage?

@LukeShu I created #199 to track this.

@danehans danehans merged commit 3003c65 into envoyproxy:main Aug 11, 2022
@danehans danehans deleted the resource_table_fixes branch August 26, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider/kubernetes Issues related to the Kubernetes provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants